Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browse): Added the prototype for the uploads page #53

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

Shruti3004
Copy link
Collaborator

Description

Added the Browse page prototype.

Changes

  • Added the api for browse page.
  • Created the layout for the browse page.

How to test

Visit to /browse

Screenshots

Screenshot from 2021-07-01 07-14-51

@GMishx GMishx added needs review Need code review needs test Needs testing labels Jul 1, 2021
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working fine.

@GMishx
Copy link
Member

GMishx commented Jul 1, 2021

Just one suggestion, I am not sure what are your plans, but the recursive can be set to false to fetch uploads only for the current folder.

And pagination is currently not working right?

@GMishx GMishx added ready PR is ready for merge and removed needs review Need code review needs test Needs testing labels Jul 1, 2021
@GMishx
Copy link
Member

GMishx commented Jul 1, 2021

And just to let you know, the filter PR is also ready: fossology/fossology#2038

@Shruti3004
Copy link
Collaborator Author

Just one suggestion, I am not sure what are your plans, but the recursive can be set to false to fetch uploads only for the current folder.

And pagination is currently not working right?

Yes @GMishx, working on it, Actually we decided to divide our pr into chunks.

@Shruti3004
Copy link
Collaborator Author

And just to let you know, the filter PR is also ready: fossology/fossology#2038

Ohh, great but I have checked it is not been merged yet as soon as it get merged we will work on that.

@Shruti3004
Copy link
Collaborator Author

@GMishx Resolved the merge conflicts

Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>
@GMishx GMishx merged commit 0eb04c0 into development Jul 1, 2021
@GMishx GMishx deleted the feat/browse branch July 1, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants