feat(package): Add model packages #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
reviewed
Jul 2, 2022
| logreg = Pipeline( | ||
| [ | ||
| ("vect", CountVectorizer()), | ||
| ("tfidf", TfidfTransformer()), |
There was a problem hiding this comment.
Just an idea came to my mind. Can we try using BM25 in place of TF-IDF and see if there are any improvements? This will also help us compare the two for the license domain.
There was a problem hiding this comment.
Ya sure, I will try using BM25.
There was a problem hiding this comment.
For now I have modified the code as suggested and also added the package for linear support vector machine model.
Thanks:)
its-sushant
force-pushed
the
model_packages
branch
from
e4cb92c
to
718370f
Compare
its-sushant
changed the title
hastagAB
reviewed
Jul 6, 2022
Kaushl2208
suggested changes
Jul 8, 2022
| ("clf", LinearSVC(n_jobs=1, C=1e5)), | ||
| ] | ||
| ) | ||
| print("Model training is started!") |
There was a problem hiding this comment.
Suggested change
| print("Model training is started!") | |
| print("Model training has started!") |
| train_data = data() | ||
|
|
||
| X_train = train_data.text | ||
| y_train = train_data.short_name |
There was a problem hiding this comment.
Suggested change
| y_train = train_data.short_name | |
| Y_train = train_data.short_name |
or lower caps the X_train as well :)
| ] | ||
| ) | ||
| print("Model training is started!") | ||
| logreg_model = logreg.fit(X_train, y_train) |
There was a problem hiding this comment.
Same here, The X_train and Y_train uniformity
| def train(): | ||
| train_data = data() | ||
|
|
||
| X_train = train_data.text |
| ] | ||
| ) | ||
| print("Model training is started!") | ||
| logreg_model = logreg.fit(X_train, y_train) |
| ("clf", LogisticRegression(n_jobs=1, C=1e5)), | ||
| ] | ||
| ) | ||
| print("Model training is started!") |
There was a problem hiding this comment.
Suggested change
| print("Model training is started!") | |
| print("Model training has started!") |
its-sushant
force-pushed
the
model_packages
branch
from
718370f
to
00f460f
Compare
Kaushl2208
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add model training code and the python package code for logistic regression linear support vector machine model that has been created.
File Structure
How to train
For training the model run
python path/to/model_train.pyNotes
Test for the implemented model is done locally by creating the agents for logisticRegression and linearsvc on atarashi and the accuracy score that has been tested using evaluator.py is 63% for both models.
CC: @GMishx @Kaushl2208 @hastagAB @ag4ums @vasudevmaduri