fix(pep518): Install dependency using PEP 518 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2019
Closed
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
|
@robguinness , can you please check with this new commit? |
The external data is now the part of the package. This will help in placing them accordingly. Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
ag4ums
approved these changes
Mar 28, 2019
ag4ums
added a commit
that referenced
this pull request
Mar 28, 2019
fix(pep518): Install dependency using PEP 518
Tested by : anupam.ghosh@siemens.com
Reviewed by : anupam.ghosh@siemens.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use PEP 518 to declare and install dependencies.
Now, to install atarashi, PIP >= 18.1 is required (due to PEP 508).
To install:
pip install .Fixes #45