Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/content disposition #97

Merged
merged 9 commits into from
Apr 22, 2022
Merged

Fix/content disposition #97

merged 9 commits into from
Apr 22, 2022

Conversation

deveaud-m
Copy link
Collaborator

This patch improves robustness against different type of quotes (or no quotes at all) in the Content-Disposition header while reading the name of the downloaded report.

Fixes #96

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #97 (976eabe) into master (56f639c) will decrease coverage by 0.42%.
The diff coverage is 78.12%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   89.94%   89.52%   -0.43%     
==========================================
  Files          11       11              
  Lines        1333     1346      +13     
==========================================
+ Hits         1199     1205       +6     
- Misses        134      141       +7     
Impacted Files Coverage Δ
fossology/__init__.py 93.29% <ø> (ø)
fossology/foss_cli.py 82.25% <0.00%> (ø)
fossology/obj.py 93.30% <ø> (ø)
fossology/uploads.py 85.46% <75.00%> (-1.05%) ⬇️
fossology/report.py 100.00% <100.00%> (ø)
fossology/__main__.py 0.00% <0.00%> (-75.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f639c...976eabe. Read the comment docs.

@deveaud-m
Copy link
Collaborator Author

Due to breaking changes in Fossology API version 1.4.0, new commits were needed to support the new PATCH und PUT methods for /upload endpoint.

Additionally, fix #95 by adding a wait_time option to download_report.

@deveaud-m deveaud-m merged commit 86ba9bd into master Apr 22, 2022
@deveaud-m deveaud-m deleted the fix/content-disposition branch April 22, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Disposition header in Fossology /report responses with different formatting
1 participant