Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of Copyright Statements: UI label misleading #1876

Closed
mcjaeger opened this issue Jan 21, 2021 · 3 comments · Fixed by #1883
Closed

Reuse of Copyright Statements: UI label misleading #1876

mcjaeger opened this issue Jan 21, 2021 · 3 comments · Fixed by #1883

Comments

@mcjaeger
Copy link
Member

Description

For copyrights, the reuse is always there, it depends on the file hash. So there are two type of copyright work that is being reused:

  1. edit a particular copyright statement
  2. deactivate a false positive copyright statement (usually something catched from a license text ...)

Both are automatically reuse at all uploads, thus the UI element:

Screenshot 2021-01-21 at 12 04 00

is confusing: why there should be the checkbox if reuse happens anyway?

in fact reuse will not kick in for deactivations, if there will be a new copyright agent version.

Thus, what is proposed is to rename the label to Reuse deactivate copyright when agent version changes (or whatever ... just an example)

@Prodyte
Copy link
Contributor

Prodyte commented Jan 28, 2021

hey, I would like to do this @GMishx.

@GMishx
Copy link
Member

GMishx commented Jan 28, 2021

Hey @Prodyte , sure. I will assign this to you.
Just one addition, please check the title text for the i image as well. I am not sure what it says at the moment 😅

@Prodyte
Copy link
Contributor

Prodyte commented Jan 28, 2021

Just one addition, please check the title text for the i image as well. I am not sure what it says at the moment

it says 'use to copy only deactived copyright decisions from the reused package'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants