Skip to content

Commit

Permalink
Item14866: normalize web parameter before caching
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelDaum committed Nov 12, 2019
1 parent dc7aea7 commit f153358
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 11 deletions.
7 changes: 4 additions & 3 deletions data/System/FlexFormPlugin.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
%META:TOPICINFO{author="ProjectContributor" comment="" date="1528135318" format="1.1" version="1"}%
%META:TOPICINFO{author="ProjectContributor" comment="" date="1573556648" format="1.1" version="1"}%
---+!! %TOPIC%
%FORMFIELD{"Description"}%

Expand Down Expand Up @@ -147,7 +147,7 @@ Note that the actual results may vary depending on the formfield type of the !Da

---++ Form layouts

There are three layouts that are supported by =%RENDERFORDISPLAY= and %RENDERFOREDIT= that may be specified using the =type="..."= parameter:
There are three layouts that are supported by =%RENDERFORDISPLAY= and =%RENDERFOREDIT= that may be specified using the =type="..."= parameter:

* =table=
* =div=
Expand Down Expand Up @@ -199,6 +199,7 @@ than horizontal on mobile devices.

---++ Change History
%TABLE{columnwidths="7em" tablewidth="100%"}%
| 12 Nov 2019: | normalize web parameter before caching topic objects |
| 04 Jul 2018: | added =type= parameter to RENDERFORDISPLAY and RENDERFOREDIT |
| 30 Aug 2016: | added =includeattr=, =excludeattr= to RENDERFORMDEF |
| 02 Sep 2016: | improved support to translate formfields using Foswiki:Extensions.MultiLingualPlugin |
Expand Down Expand Up @@ -246,7 +247,7 @@ than horizontal on mobile devices.

%META:FORM{name="PackageForm"}%
%META:FIELD{name="Author" title="Author" value="Foswiki:MichaelDaum"}%
%META:FIELD{name="Copyright" title="Copyright" value="© 2009-2018 Michael Daum http://michaeldaumconsulting.com"}%
%META:FIELD{name="Copyright" title="Copyright" value="© 2009-2019 Michael Daum http://michaeldaumconsulting.com"}%
%META:FIELD{name="Description" title="Description" value="%25$SHORTDESCRIPTION%25"}%
%META:FIELD{name="Home" title="Home" value="Foswiki:Extensions/%TOPIC%"}%
%META:FIELD{name="License" title="License" value="[[http://www.gnu.org/licenses/gpl.html][GPL (Gnu General Public License)]]"}%
Expand Down
6 changes: 3 additions & 3 deletions lib/Foswiki/Plugins/FlexFormPlugin.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Plugin for Foswiki - The Free and Open Source Wiki, http://foswiki.org/
#
# Copyright (C) 2009-2018 Michael Daum http://michaeldaumconsulting.com
# Copyright (C) 2009-2019 Michael Daum http://michaeldaumconsulting.com
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
Expand All @@ -18,8 +18,8 @@ package Foswiki::Plugins::FlexFormPlugin;
use strict;
use warnings;

our $VERSION = '6.00';
our $RELEASE = '04 Jun 2018';
our $VERSION = '6.01';
our $RELEASE = '21 Nov 2019';
our $SHORTDESCRIPTION = 'Flexible way to render <nop>DataForms';
our $NO_PREFS_IN_TOPIC = 1;
our $renderForEditInstance;
Expand Down
4 changes: 2 additions & 2 deletions lib/Foswiki/Plugins/FlexFormPlugin/Base.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Plugin for Foswiki - The Free and Open Source Wiki, http://foswiki.org/
#
# Copyright (C) 2009-2018 Michael Daum http://michaeldaumconsulting.com
# Copyright (C) 2009-2019 Michael Daum http://michaeldaumconsulting.com
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
Expand Down Expand Up @@ -51,7 +51,7 @@ sub getTopicObject {
$topic ||= '';
$rev ||= '';

$web =~ s/\//\./go;
$web =~ s/\//\./g;
my $key = $web . '.' . $topic . '@' . $rev;
my $topicObj = $topicObjs{$key};

Expand Down
2 changes: 1 addition & 1 deletion lib/Foswiki/Plugins/FlexFormPlugin/RenderForDisplay.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Plugin for Foswiki - The Free and Open Source Wiki, http://foswiki.org/
#
# Copyright (C) 2009-2018 Michael Daum http://michaeldaumconsulting.com
# Copyright (C) 2009-2019 Michael Daum http://michaeldaumconsulting.com
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
Expand Down
2 changes: 1 addition & 1 deletion lib/Foswiki/Plugins/FlexFormPlugin/RenderForEdit.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Plugin for Foswiki - The Free and Open Source Wiki, http://foswiki.org/
#
# Copyright (C) 2009-2018 Michael Daum http://michaeldaumconsulting.com
# Copyright (C) 2009-2019 Michael Daum http://michaeldaumconsulting.com
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
Expand Down
2 changes: 1 addition & 1 deletion lib/Foswiki/Plugins/FlexFormPlugin/RenderFormDef.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Plugin for Foswiki - The Free and Open Source Wiki, http://foswiki.org/
#
# Copyright (C) 2009-2018 Michael Daum http://michaeldaumconsulting.com
# Copyright (C) 2009-2019 Michael Daum http://michaeldaumconsulting.com
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
Expand Down

0 comments on commit f153358

Please sign in to comment.