Item13283: fixing use of uninitialized value

foswiki · Feb 27, 2015 · 14eb8ee · 14eb8ee
1 parent ae3e3f7
commit 14eb8ee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/Foswiki/Plugins/OEmbedPlugin.pm b/lib/Foswiki/Plugins/OEmbedPlugin.pm
@@ -20,8 +20,8 @@ use warnings;
 
 use Foswiki::Func ();
 
-our $VERSION = '5.10';
-our $RELEASE = '23 Feb 2015';
+our $VERSION = '5.11';
+our $RELEASE = '27 Feb 2015';
 our $SHORTDESCRIPTION = 'Easy embedding of third party content';
 our $NO_PREFS_IN_TOPIC = 1;
 our $core;

diff --git a/lib/Foswiki/Plugins/OEmbedPlugin/Core.pm b/lib/Foswiki/Plugins/OEmbedPlugin/Core.pm
@@ -116,9 +116,9 @@ sub provider {
       }
       print "  },\n";
     }
-
 
-    print "},\n\n"; 
+
+    print "},\n\n";
   }
 }
 
@@ -214,7 +214,9 @@ sub EMBED {
 
     $width .= 'px' if defined $width && $width =~ /^[\d\.]+$/;
     $height .= 'px' if defined $height && $height =~ /^[\d\.]+$/;
-
+
+    $height ||= '';
+    $width ||= '';
 
     $result =~ s/\$url\b/$url/g;    # ... if left over
     $result =~ s/\$class\b/$class/g;