Item12952: Configure crashes HTML Validation tests

Use a literal for the rejection reason. The tests still fail but at least the test suite doesn't crash.
foswiki · Sep 5, 2014 · 336f979 · 336f979
1 parent 1edb29f
commit 336f979
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/UnitTestContrib/test/unit/HTMLValidationTests.pm b/UnitTestContrib/test/unit/HTMLValidationTests.pm
@@ -51,6 +51,7 @@ sub loadExtraConfig {
 
     # $this - the Test::Unit::TestCase object
     $Foswiki::cfg{JQueryPlugin}{Plugins}{PopUpWindow}{Enabled} = 1;
+    $Foswiki::cfg{ConfigureFilter} = '^(scum)$';
 
     $this->SUPER::loadExtraConfig( $context, @args );
 

diff --git a/core/lib/Foswiki/UI/Configure.pm b/core/lib/Foswiki/UI/Configure.pm
@@ -55,14 +55,13 @@ sub configure {
         unless ( $session->{user} =~ m/$filter/ ) {
             throw Foswiki::AccessControlException( 'VIEW',
                 $session->{user}, 'System', 'Configuration',
-                $Foswiki::Meta::reason );
+                'Denied by {ConfigureFilter} Setting' );
         }
     }
     else {
         unless ( Foswiki::Func::isAnAdmin() ) {
             throw Foswiki::AccessControlException( 'VIEW',
-                $session->{user}, 'System', 'Configuration',
-                $Foswiki::Meta::reason );
+                $session->{user}, 'System', 'Configuration', 'Not an admin' );
         }
     }