Skip to content

Commit

Permalink
Item1303: parser uninited var in concat errormessages filling my disk
Browse files Browse the repository at this point in the history
git-svn-id: http://svn.foswiki.org/trunk@3126 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
  • Loading branch information
SvenDowideit authored and SvenDowideit committed Mar 15, 2009
1 parent 6c12056 commit 69895c7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/lib/Foswiki/Prefs/Parser.pm
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ sub parse {
# SMELL: What is this mysterious undocumented code for? It inserts
# PREFERENCE_<pref title> but that's all I can work out :-(
# I can't find any clues in Codev either.
$prefs->insert( $type, 'PREFERENCE_' . $field->{title}, $value );
# (later) added ifdefined, to remove error log line
$prefs->insert( $type, 'PREFERENCE_' . $field->{title}, $value ) if (defined($field->{title}));
}

# Note that the use of the "S" attribute to support settings in
Expand All @@ -82,7 +83,6 @@ sub parse {
if ($form) {
my @fields = $topicObject->find('FIELD');
foreach my $field (@fields) {
my $title = $field->{title};
my $attributes = $field->{attributes};
if ( $attributes && $attributes =~ /S/o ) {
my $value = $field->{value};
Expand Down

0 comments on commit 69895c7

Please sign in to comment.