Change wavelenght format to match pps-level1c #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPS (2021) need the wavelenght attribute to be a list with min, center, max value for the wavelength.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 76.92% 76.93% +0.01%
==========================================
Files 21 21
Lines 1417 1418 +1
Branches 108 108
==========================================
+ Hits 1090 1091 +1
Misses 302 302
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 949286697
💛 - Coveralls |
sfinkens
reviewed
Jun 7, 2021
level1c4pps/seviri2pps_lib.py
Outdated
| @@ -260,6 +260,7 @@ def set_attrs(scene): | |||
| idtag = PPS_TAGNAMES[band] | |||
| scene[band].attrs['id_tag'] = idtag | |||
| scene[band].attrs['description'] = 'SEVIRI ' + str(band) | |||
| scene[band].attrs['wavelength'] = scene[band].attrs['wavelength'][0:3] | |||
There was a problem hiding this comment.
You could use attrs['wavelength'].min/max/central to improve readability. In the tests you could do
from satpy.dataset.dataid import WavelengthRange
scene = Scene(..., attrs={..., 'wavelength': WavelengthRange(1, 2, 3)})
added 2 commits
June 18, 2021 10:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPS (2021) need the wavelength attribute to be a list with min, center, max
value for the wavelength.
pytest level1c4ppsflake8