Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The MessagePackSerializer should add a optional parameter to determine whether compress the serialized data. #118

Closed
edwardmeng opened this issue Jan 24, 2018 · 1 comment
Closed

The MessagePackSerializer should add a optional parameter to determine whether compress the serialized data. #118

edwardmeng opened this issue Jan 24, 2018 · 1 comment
Labels
bug help wanted

Comments

@edwardmeng
Copy link
Contributor

https://github.com/FoundatioFx/Foundatio/blob/14db27dd26f54ff63841629f115eac47b7d57b12/src/Foundatio/Serializer/MessagePackSerializer.cs

When the value of parameter 'compress' is set true, it should serialize/deserialize with MessagePack.LZ4MessagePackSerializer.NonGeneric, otherwise should use MessagePack.MessagePackSerializer.NonGeneric
@niemyjski
Copy link
Member

Can you please submit a pr for this (probably would be good to have a quick test for it as well.

@edwardmeng edwardmeng mentioned this issue Jan 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niemyjski @edwardmeng