-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests added and enable self signed certs #69 #78
Conversation
I'm a bit confused how this shows mTLS is already implemented here - what is in this "bundle cert" used that has all the components needed to do mutual authentication? For the grpc clients there are also currently 3 fields expected (cert, key, ca) and for users just deploying this and using config, I feel we shouldn't need to make it obvious that "detectors" are using http clients for now and thus configure this way, vs "chunkers" and "generation" use grpc clients for now - and thus configure with non-bundled fields. As much as possible the expectations on "what fields need to be provided" should be as consistent as much as possible. |
…ndle, client cert and key, and ca cert foundation-model-stack#69
All requested changes made and finished implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the linting failures in the build?
Co-authored-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
@evaline-ju I think it is good for review now! |
using a single bundle cert was already implemented at
fms-guardrails-orchestrator/src/clients.rs
Line 113 in 4973351
I tested running the local PII with mTLS and self signed certificated.