Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for tuning.aim_loader #71

Closed
tedhtchang opened this issue Mar 5, 2024 · 4 comments
Closed

Add unit tests for tuning.aim_loader #71

tedhtchang opened this issue Mar 5, 2024 · 4 comments

Comments

@tedhtchang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Add unit tests for the tuning/aim_loader.py module.

Describe the solution you'd like

If possible, each function should have test cases in the file tests/tuning/test_aim_loader.py
and pass test with the command pytest tests/tuning/test_aim_loader.py

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the feature request here.

@tedhtchang tedhtchang changed the title Add unit tests for aim_loader Add unit tests for tuning.aim_loader Mar 7, 2024
@Ssukriti
Copy link
Collaborator

Ssukriti commented Mar 8, 2024

@alex-jw-brooks when you get time, please comment if we need a unit test for this

@dushyantbehl
Copy link
Contributor

@Ssukriti @alex-jw-brooks we do need unit test for this function as the underlying api is 3rd party and arguments are involved. I can happily add them as I wrote this first hand and am aware of the behavior.

@Ssukriti
Copy link
Collaborator

Thank you , yes please contribute . We are prioritizing reviews of unit tests before we add too much more code 🙂

@anhuong
Copy link
Collaborator

anhuong commented Jul 25, 2024

closing this issue as unit tests were added for AIM which is now in tracker https://github.com/foundation-model-stack/fms-hf-tuning/blob/main/tests/trackers/test_aim_tracker.py

@anhuong anhuong closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants