Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input args to max_seq_length and training_data_path #94

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

anhuong
Copy link
Collaborator

@anhuong anhuong commented Mar 14, 2024

Description of the change

  • update max_model_length to max_seq_length to match sfttrainer input arg
  • update data_path to training_data_path to distinguish between training and validation data
  • update unit tests and docs with new args

Related issue number

closes: #36

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

Signed-off-by: Anh-Uong <anh.uong@ibm.com>
Signed-off-by: Anh-Uong <anh.uong@ibm.com>
@Ssukriti Ssukriti merged commit fc84498 into foundation-model-stack:main Mar 14, 2024
3 checks passed
jbusche pushed a commit to jbusche/fms-hf-tuning that referenced this pull request Mar 25, 2024
…n-model-stack#94)

* update max_model_length to max_seq_length to match sfttrainer

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

* update data_path to training_data_path and tests

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

---------

Signed-off-by: Anh-Uong <anh.uong@ibm.com>
anhuong added a commit to anhuong/fms-hf-tuning that referenced this pull request Apr 3, 2024
…n-model-stack#94)

* update max_model_length to max_seq_length to match sfttrainer

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

* update data_path to training_data_path and tests

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

---------

Signed-off-by: Anh-Uong <anh.uong@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update input args for sftTrainer
2 participants