close channel when thread resouces are freed #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand how does it solves the problem? If a thread is being closed by the thread pool how do you know about it? |
|
Oh I think I got it, you override the finalize... |
|
Did you test it is actually cleans up the channel? I mean when the Thread is being shrink by the thread pool are you sure the ChannelWrapper ThreadLocal is being garbage collected? |
|
I tested it with simple system.gc() call after thread.start()
It works fine. I still want to test it NTN with jetty. I hope to do it
tomorrow.
בתאריך 29 בנוב׳ 2017 13:33, "Izeidman" <notifications@github.com> כתב:
… Did you test it is actually cleans up the channel? I mean when the Thread
is being shrink by the thread pool are you sure the ChannelWrapper
ThreadLocal is being garbage collected?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARBqgzDadCbLMNL_ywh81KcArrhJ1yJ7ks5s7UDzgaJpZM4QuzVV>
.
|
|
Ok, I would be glad to help with this test if you like. And if it really works it is the most elegant and most correct solution! |
|
I test it on my environment and it works very well! merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick and less risky solution for the zombies channel