Configurable request/response body in verbose #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekhar1983
reviewed
Sep 13, 2017
| @@ -189,7 +189,7 @@ protected void addVerbosePropertiesStart(final HttpServletRequest request, Strin | |||
| if (requestHeaders != null) { | |||
| this.properties.put(HttpVerbosePropertyKey.RequestHeaders.name(), requestHeaders); | |||
| } | |||
| if (requestBody != null) { | |||
| if (requestBody != null && !ConfigurationUtil.INSTANCE.allowHeadersAndResponseBodyOnly()) { | |||
There was a problem hiding this comment.
See if (requestBody != null && ConfigurationUtil.INSTANCE.allowHeadersAndRequestBodyOnly()) is more appropriate.Otherwise, for not to dump request body, we need to set responseBodyOnly flag to true, which is bit confusing IMO. Check the the same in other places( Line 232 and 245)
mrajaian
force-pushed
the
requestResponseInVerboseConfiguration
branch
from
54c89ea
to
9e356c8
Compare
|
@mzemmour Please review |
mzemmour
approved these changes
Sep 14, 2017
ilayze
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.