Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add th.text-center styling #468

Merged
merged 4 commits into from Jun 10, 2016
Merged

Add th.text-center styling #468

merged 4 commits into from Jun 10, 2016

Conversation

paroxp
Copy link

@paroxp paroxp commented Jun 10, 2016

Started of with the addition to .text-center scss definition, as TH has not been considered there.

For maintainability purpose, I've refactored the way of these class declarations. I mean, with the previous approach, table.text-left, table.text-right, td.text-left and td.text-right were not even defined. My approach is to rule them all.

I've formatted the code, so it's clean, removed few blank lines, added spaces where necessary and removed the duplication of an attribute.

Hope that's fine.

Got confused with the contributing guide, so I've followed the one below:
https://github.com/zurb/foundation-emails/blob/develop/CONTRIBUTING.md#submitting-pull-requests

@rafibomb
Copy link
Member

Love all these changes! Just one question: what is the need for the extra indentation in the button maps?

@paroxp
Copy link
Author

paroxp commented Jun 10, 2016

Hi there,

Actually, this indentation has no particular reason, you're right.

I must have confused few bits and pieces, when IDE picked on it. Feel free to ignore it.

@rafibomb
Copy link
Member

Love it - thanks!

@rafibomb rafibomb merged commit 24f1b22 into foundation:develop Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants