-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
foreground() causes error in 6.3.0 gem upgrade #214
Comments
It's a breaking change listed in the
Following the comment, you can see that the
So I think you should just use |
For anyone with this same issue, try these commands:
gem "foundation-rails", "6.2.4.0" to gem "foundation-rails", "6.3.0.0"
|
Note that this will overrides any customization previously made to Sadly there is no easy way to update the |
Breaking changes always means side effects. Obviously not the preferred way to fix it. But I am in the middle of development, so the side effects are minimal for me. |
Based on recommendation in foundation/foundation-rails#214 Fixes #160 because the warnings go away when we upgrade
…use this error. Temporary fix - likely to remove foundation if continues as issue
foundation/foundation-rails#214 Versioned up and did damage control in another branch but the site didn’t look the same and unclear how much work it would have been to get back to status quo. If this version will work for us it’s certainly easier Axed the aws.rb that we don’t seem to need any more with this batch of deps
Upgrading to 6.3.0.0 of this gem breaks due to changes in the Foundation 6.3.0 upgrade
How can we reproduce this bug?
Ruby 2.3.3
Rails 5.0.1
foundation-rails 6.3.0.0
in yourGemfile
:bundle update
Example:
Run a process that requires a recompilation of scss files (in my case, a test with RSpec)
What did you expect to happen?
There should not be an error message
What happened instead?
Other information
I'm not sure what I'm supposed to do to accomodate these changes, but I think the problems point back to these changes:
foundation/foundation-sites#9319 (comment)
Temporary Fix
I commented out the
// @include foundation-badge;
and// @include foundation-label;
lines in thefoundation_and_overrides.scss
file and things started working againThe text was updated successfully, but these errors were encountered: