Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.4.0 mixin xy-cell-breakpoints gone? #10276

Closed
Moonbase59 opened this issue Jun 28, 2017 · 5 comments
Closed

6.4.0 mixin xy-cell-breakpoints gone? #10276

Moonbase59 opened this issue Jun 28, 2017 · 5 comments

Comments

@Moonbase59
Copy link

Moonbase59 commented Jun 28, 2017

I’m about to try the xy-grid for a new site, using semantic HTML and as few "presentation classes" as possible. Meaning, I try to pack most of it into the CSS using SASS.

A few days ago, I could find (and was happy about) a mixin "xy-cell-breakpoints" in the docs (http://foundation.zurb.com/sites/docs/xy-grid.html#responsive-grids), but it seems to have gone:

Error in plugin 'sass'
Message:
    src/assets/scss/gridtest.scss
Error: no mixin named xy-cell-breakpoints

       Backtrace:
       	src/assets/scss/gridtest.scss:38
        on line 38 of src/assets/scss/gridtest.scss
>>   @include xy-cell-breakpoints((small: full, medium: 9));
   -----------^

What’s the status of this one?

Just asking because I feel we tend to get lazy, by including all these fancy Foundation classes in the HTML markup and thus effectively mix up content and presentation again.

Personally, I’d very much prefer "simple" semantic HTML5 like

<header class="pageheader">
  <nav>
  </nav>
</header>

<main>
  <article class="article">
  </article>
</main>

<aside class="aside">
  <section class="aside__section">
  </section>
</aside>

<footer id="pagefooter" class="pagefooter">
  <section class="pagefooter__section">
  </section>
</footer>

and then do the main part in SASS, more or less like

body {
  @include xy-grid-container(1200);
}

/* PAGE HEADER */
header.pageheader {
  background-color: red;
  @include xy-grid(horizontal, true);
}

/* MAIN CONTENT */
main {
  background-color: yellow;
  @include xy-grid(horizontal, true);
  @include xy-gutters();
}

.article {
  background-color: lightyellow;
  @include xy-grid(horizontal, true);
  @include xy-gutters();
}

.article__hero-image {
  @include xy-cell-breakpoints((small: full));
}

.article__info {
  @include xy-cell-breakpoints((small: full, medium: 9));
}

.article__content {
  @include xy-cell-breakpoints((small: full, medium: 9));
}

.article__end {
  @include xy-cell-breakpoints((small: full, medium: 9));
}

What do you think?

@IamManchanda
Copy link
Contributor

cc @kball @brettsmason ?

@kball
Copy link
Contributor

kball commented Jun 28, 2017

Bother I think this made it into the docs at some point but the final PR for this was never merged as we did not get it working with responsive gutters yet (handling responsive gutters with the margin-based grids is unfortunately quite complex).

@Moonbase59 would you be interested in helping get PR across the line? (#10171)

@Moonbase59
Copy link
Author

@kball I might be able to offer some testing maybe, but still consider myself quite a Foundation beginner, especially regarding the xy-grid.

@bmarshall511
Copy link

Curious what the status of this is?

@guci0
Copy link

guci0 commented Dec 4, 2017

//Error: no mixin named xy-cell-breakpoints 🤔

ncoden added a commit to ncoden/foundation-sites that referenced this issue Jan 2, 2018
ncoden added a commit that referenced this issue Jan 4, 2018
…reakpoints-10276

 docs: remove undefined mixin `xy-cell-breakpoints` #10276
@ncoden ncoden closed this as completed Jan 4, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this issue Jun 16, 2018
…y-cell-breakpoints-10276 for v6.5.0

4b3be7d docs: remove undefined mixin `xy-cell-breakpoints` foundation#10276

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants