Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Off-canvas] Docs - open nested off-canvas push does overlap instead. #10328

Closed
rafibomb opened this issue Jul 3, 2017 · 5 comments
Closed

Comments

@rafibomb
Copy link
Member

rafibomb commented Jul 3, 2017

Click example here:
http://foundation.zurb.com/sites/docs/off-canvas.html#nested-off-canvas
open nested off-canvas push

Overlaps instead of pushes

@brettsmason
Copy link
Contributor

@rafibomb This is a docs not being clear enough issue. If you see the callout in that section it mentions nested is only possible for overlap (if set to push it will force it to a push). See here for details on why this was done.

So the functionality is right, but the docs example is possibly misleading. cc @kball

@kball
Copy link
Contributor

kball commented Jul 3, 2017

@SassNinja would you be able to take a pass on improving the docs here?

@SassNinja
Copy link
Contributor

@kball I'm not sure how to explain it better: there's a warning callout in the docs and I've mentioned it in the opened off-canvas
Since push transition is currently not possible for nested elements, I'm forced to use overlap transition.

@rafibomb since you haven't noticed this note at first sight, maybe you can let me know what part of the docs you usually focus? Would a another position/color of the callout help?

@DanielRuf
Copy link
Contributor

@SassNinja any idea what we can do here? Do you plan to improve this part?

@SassNinja
Copy link
Contributor

SassNinja commented Feb 21, 2018

The plan was to wait for @rafibomb to explain more detailed what was confusing him ;)

However I've just made PR that updates the off-canvas docs #10964
This should make it much clearer and fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants