Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid xy grid-frame scrolling panel stopped working #10793

Closed
octaviou opened this issue Nov 29, 2017 · 10 comments · Fixed by #11085
Closed

grid xy grid-frame scrolling panel stopped working #10793

octaviou opened this issue Nov 29, 2017 · 10 comments · Fixed by #11085

Comments

@octaviou
Copy link

octaviou commented Nov 29, 2017

When using grid yx grid-frame, the scrolling panel (sidebar , body) stopped working. It does some sort of overflow: hidden.

How to reproduce this bug:

  1. Step one
    copy the grid code example from
    https://foundation.zurb.com/sites/docs/xy-grid.html#grid-frame
  2. Step two
  • try to scroll on the "Independent scrolling sidebal" panel on any browser

What should happen:

the panel should scroll down/up

What happened instead:

its fixed and the content is cropped

Browser(s) and Device(s) tested on:

Chrome latest, mac

Foundation Version(s) you are using:

6.4.4-rc1

Test case link:

@rafibomb
Copy link
Member

rafibomb commented Feb 2, 2018

Seems to work here: https://codepen.io/rafibomb/pen/mXeaZK

Is this specific to the RC version?

@Nagogus
Copy link

Nagogus commented Feb 20, 2018

Same for me. Stopped working in Chrome 63 and Safari 11 on macos on 6.4.4-rc1 but works on 6.4.3.
Works fine in Firefox

@ncoden ncoden added the 🐛bug label Feb 20, 2018
@DanielRuf
Copy link
Contributor

@ncoden should I do some bisecting here then when I find the time or someone else?

@ncoden
Copy link
Contributor

ncoden commented Feb 20, 2018

The first that find the time for this issue will assign himself to it ;)

@DanielRuf DanielRuf self-assigned this Feb 20, 2018
@DanielRuf
Copy link
Contributor

Result of the bisecting:

$ git bisect bad
b1924e099540e4e7411a948d776691e1e5746fbf is the first bad commit
commit b1924e099540e4e7411a948d776691e1e5746fbf
Author: Kevin Ball <kmball11@gmail.com>
Date:   Thu Sep 14 12:26:09 2017 -0700

    Add height pinning to cell-block-y

:040000 040000 7ebe7118fa943345d71b494005a86a690065e32a 39bafb6936863eafbc4b53bd7a034fad30f80d49 M      scss

@robslotboom
Copy link

I have re-installed foundation-sites@6.4.4-rc1 but it is still not working.
The strange thing is that the example at codepen does work.

Did I missed something???

@DanielRuf
Copy link
Contributor

I have re-installed foundation-sites@6.4.4-rc1 but it is still not working.
The strange thing is that the example at codepen does work.

Did I missed something???

The change / bugfix was introduced later and is only in the develop branch. Released versions are not changed afterwards.

@robslotboom
Copy link

@DanielRuf,

Thank you for the quick response.
While waiting for an upgrade I’ve added the following to the css:

div[class$='cell-block-y'] {
    height: auto;
}

Cheers,
Rob

@DanielRuf
Copy link
Contributor

Why not just .cell-block-y {}?

@robslotboom
Copy link

robslotboom commented Jun 14, 2018

Because of the example :-)

<div class="cell medium-4 medium-cell-block-y">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants