Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing vertical scrollbar in xy-grid frame #11085

Merged
merged 1 commit into from Mar 23, 2018
Merged

fix: add missing vertical scrollbar in xy-grid frame #11085

merged 1 commit into from Mar 23, 2018

Conversation

DanielRuf
Copy link
Contributor

b1924e0 created a regression. height:100% removed the scrollbar from the vertical xy-grid frame.

This PR fixes this and uses the recommended min-height:100% setting.

Closes #10793

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #10649 (comment)

👍 LGTM

@ncoden ncoden merged commit f2d9fe9 into foundation:develop Mar 23, 2018
@DanielRuf DanielRuf deleted the fix/xy-grid-frame-scrollbar-10793 branch March 24, 2018 07:09
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…rollbar-10793 for v6.5.0

42a05a8 fix: add missing vertical scrollbar in xy-grid frame

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid xy grid-frame scrolling panel stopped working
2 participants