We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magellan with data-offset should should be triggered at offset positions
data-offset
All menu items, but not the first one, is triggered at the correct position.
update /js/foundation.magellan.js line 170:
/js/foundation.magellan.js
from if(newScrollPos < this.points[0]){ /* do nothing */ }
if(newScrollPos < this.points[0]){ /* do nothing */ }
to: if(newScrollPos < this.points[0] - this.options.offset - (isScrollingUp ? this.options.threshold : 0)){ /* do nothing */ }
if(newScrollPos < this.points[0] - this.options.offset - (isScrollingUp ? this.options.threshold : 0)){ /* do nothing */ }
Test Case: https://codepen.io/mingyeungs/full/oRerpB
The text was updated successfully, but these errors were encountered:
Yup, we can confirm this problem! Any chance to fix this?
Sorry, something went wrong.
I can confirm that @mingyeungs fix works fine!
Fixed foundation#11754
97c7f49
4bc515a
No branches or pull requests
What should happen?
Magellan with
data-offset
should should be triggered at offset positionsWhat happens instead?
All menu items, but not the first one, is triggered at the correct position.
Possible Solution
update
/js/foundation.magellan.js
line 170:from
if(newScrollPos < this.points[0]){ /* do nothing */ }
to:
if(newScrollPos < this.points[0] - this.options.offset - (isScrollingUp ? this.options.threshold : 0)){ /* do nothing */ }
Test Case and/or Steps to Reproduce (for bugs)
Test Case: https://codepen.io/mingyeungs/full/oRerpB
Your Environment
Checklist
The text was updated successfully, but these errors were encountered: