-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion Menu methods do not work with Responsive Navigation #11769
Comments
This is true, but Accordion menu should.
https://foundation.zurb.com/sites/docs/accordion-menu.html#js-functions
…On Fri, Jun 7, 2019 at 12:46 AM Daniel Ruf ***@***.***> wrote:
Hi @scottsawyer <https://github.com/scottsawyer>,
At the first sight Drilldown has no toggle event listener.
https://github.com/zurb/foundation-sites/blob/develop/js/foundation.drilldown.js
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11769>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEM7VCS7CTIUIZWP6N7N23PZHR2VANCNFSM4HVOJDMA>
.
|
We have multiple issues here in Foundation Sites.
Which results in
Using the unminified version of Foundation Sites results in
As this has no |
Minified results in
Unminified results in
|
Do you think that pull will address this problem? Is it only a problem in the unminified version? Would I need the unminified version of all the plugins or just the responsiveMenu.js? |
There are probably more issues. |
Yikes, that is bad news for my project. Are you saying that the pull request you referenced in #11769 (comment) does not fix the underlying problem? |
Exactly. Can you test if all previous versions are also affected (after 6.4.3 probably) so we can do some bisecting to find the commit which caused this? This would be very helpful. |
Well, I just switched to 6.4.3 in my pen and running: |
This still seems to be an issue. Has anybody got a solution for this? |
What should happen?
When using the Responsive Menu, all of the plugin methods for the different menu types referenced should work.
Example:
Accordion Menu has the following method:
$('#element').foundation('toggle', $target);
However, this and all other accordion menu methods do not work when using accordion with responsive menu.
...
What happens instead?
Possible Solution
Best outcome would be that I have made a conceptual mistake and there is actually a way to trigger the submenu toggle with responsive menu.
Second best would be to enable all of the responsive menu plugin methods.
...
Test Case and/or Steps to Reproduce (for bugs)
Test Case: https://codepen.io/anon/pen/EzBXKy
In the console, run $('#my-menu').foundation('toggle', $target);
Set up a responsive menu with:
data-responsive-menu="drilldown medium-accordion"
Then try running any of the accordion menu methods.
Context
I am building a map of the US with a Responsive Menu of states and nested cities. I want users to be able to click a state on the map to open the corresponding submenu. Essentially, trigger a submenu via an outside trigger. Due to space constraints, I am using Drilldown menu on small and Accordion Menu on medium and up.
...
Your Environment
Checklist
The text was updated successfully, but these errors were encountered: