-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag from inside modal & ending outside closes modal (Chrome, Safari) #11789
Comments
Hi @jongilbraith, I guess this is because of |
Hi @DanielRuf, Indeed, looks the case. I looked about and found some general pointers about comparing the elements targetted in I'd like to take a look at it myself but need to read up on how to set myself for hacking on an npm module, as my abilities with javascript tooling is currently very much reliant on copy/paste. 😄 |
Hi @jongilbraith, You have to follow the instructions from the readme for contributors. Clone the repo, install the dependencies and check the scripts in pacjage.json. |
Thanks, but I was referring simply to the actual task of getting a local development copy of the module setup so I can hack on it. I'm primarily a rubyist and we're experiencing the issue in a rails codebase using webpack, but I think I'll have an easier time if I create a test app with node to tackle this. |
If webpack uses the unminified source files of Foundation you can simply change the code in there You probably have only the dist files of Foundation. using |
@DanielRuf thanks, I'll check those approaches out when I come to take a look. |
@DanielRuf @jongilbraith I had a client ux complaint come down the pipe and I traced it back to this issue. I opened up a PR to fix the bug. Can one of the maintainers review it? |
do the developers actually fix any issue or just defer them? |
This stupid issue is still happening. may be that's why bootstrap is so much popular. I am in a very bad position in front of my client just because I suggested foundation. never going to use foundation in my life ever again. |
@Sumanta9x9 please see #11816 (comment) PRs which fix this are very welcome. |
Besides this, you can use any modal library if this works better for you. |
Was there a reason this was closed? Still experiencing issue on the in the documentation & on latest version. Don't see any PR's merged in that resolve this issue. |
What should happen?
When I click and hold anywhere inside a modal, move the pointer outside of the modal and release, the modal should remain open.
What happens instead?
On Chrome (75.0.3770.142, Mac) and Safari (12.1.1, Mac), when I do this, the modal closes.
On Firefox (68.0, Mac) I do not experience this behaviour.
Test Case and/or Steps to Reproduce
This can be reproduced using the examples in the documentation (at version 6.5.3).
How to reproduce:
Worth noting, when doing the same test on the 5.5.3 documentation this behaviour isn't exhibited.
Context
We've run into issues with this in user testing. A typical scenario is interacting with a login or signup form inside a modal.
When trying to replace the existing contents of a field, users not so adept with the keyboard / mouse will attempt to manually select the contents by clicking at the start and dragging to the right, often just pulling the pointer all the way to the right far past the end of the field.
Encountering this bug, that then closes the modal for them.
Your Environment
Checklist
The text was updated successfully, but these errors were encountered: