fix: close reveal only on click-event starting outside modal

[zipzapp]

Description

This pr changes the _events binding on the reveal component to use the mousedown jQuery event instead of the click jQuery event so that modals don't close unless a click event begins outside of a the modal area, fixing the issue linked below.

• Closes Drag from inside modal & ending outside closes modal (Chrome, Safari) #11789

Types of changes

• Documentation
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (anything that would change an existing functionality)
• Maintenance (refactor, code cleaning, development tools...)

Checklist

• I have read and follow the CONTRIBUTING.md document.
• The pull request title and template are correctly filled.
• The pull request targets the right branch (develop or develop-v...).
• My commits are correctly titled and contain all relevant information.
• I have updated the documentation accordingly to my changes (if relevant).
• I have added tests to cover my changes (if relevant).

[DanielRuf]

Hi @zipzapp,

Thanks for your PR. We will check that.

What about tap / touch? I think there might be some issues.

[zipzapp]

@DanielRuf I'm not sure about all devices, but on mobile, the modal takes up the whole screen; so I don't think the issue would be applicable.

[DanielRuf]

It depends on the viewport size.

[joeworkman]

Is there anyway that you could resubmit this PR against the develop branch instead of the develop-v6.5?

[DanielRuf]

Let me check if we can change it or rebase it.

[DanielRuf]

Ok we have to rebase this PR. I'll do this later.

[DanielRuf]

I have rebased it.
Please do not add the lockfile next time.

I still think this PR does not solve it. Also develop uses click + tap.

[DanielRuf]

Hi @zipzapp,

Thanks for your PR and contribution to Foundation Sites.

I am closing this as this is not the right solution. We have to check if it is a normal tap or touchmove / swipe and track the position using touchstart / touchend.