-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Colorname Selectors SASS Warning ("You probably don't mean to use the color value black in interpolation here.") #12333
Comments
Would you like to submit a PR? |
I tried to generate these same warnings but could not. What are you running to see these? |
I got these by running our custom gulp sass build task (stripped it down to the relevant part):
Relevant Versions:
Similar issues: |
Thanks. I will work on replicating this. Any PRs would be helpful if you have the time. |
I think a better fix is to just quote your map keys, as suggested in the Sass documentation:
So change something like: $foundation-palette: (
// ...
black: #000
); To: $foundation-palette: (
// ...
"black": #000
); Perhaps the Foundation Sass should do this as well, just to set an example. |
@glen-84 great simple fix, I've tested this right now, works perfectly fine! So we just need to fix these files:
|
Investigated an issue with the button-style() mixin when using this fix:
results in:
Map:
While this works well:
|
…lation-warning-12333 FIX SASS color interpolation warning #12333
It seems that |
Compiling foundation-sites with a current version of SASS (1.43.4), throws various of those issues:
Needs to be fixed by writing the selector like so:
&#{"." + $name} {
or
&.#{"" + $name} {
.. but the first one doesn't look that ..hacky.
The text was updated successfully, but these errors were encountered: