Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbit - animation speed control, progress bar, fade #4847

Closed
vduv opened this issue Mar 29, 2014 · 5 comments
Closed

Orbit - animation speed control, progress bar, fade #4847

vduv opened this issue Mar 29, 2014 · 5 comments
Assignees

Comments

@vduv
Copy link

vduv commented Mar 29, 2014

  1. Changing the animation_speed setting (described in Docs / Components / Orbit / Advanced ) does not have any effect at all - neither if done through data-options, nor through settings directly in the .js file.
    The only setting that does control the animation speed is $orbit-animation-speed in _orbit.scss, although it is not mentioned in the Docs.
  2. With animation slowed down to, for example, 2000ms and the progress bar width set to 100%, a bug in the progress bar's behavior becomes visible - it starts at the beginning of the transition and then restarts 2 seconds later when the transition is completed.
  3. With animation type set to 'fade' and circular: true, during the transition from the last slide to the first the last slide shows up again for a moment in the middle of transition.

Have checked issues 2. and 3. in several browsers.

@vduv
Copy link
Author

vduv commented Mar 30, 2014

Forgot to mention that I'm using Foundation 5.2.1 with Orbit bug fixes #4812

@friscotx
Copy link

friscotx commented Apr 5, 2014

Looks like it is broken in 5.2.2

Very simple fade animation that works fine in all tested browsers in 5.0.0 - 4 second timer with 3 second fade:
http://orbit-transition.fullsetup.com/500.htm

However same code in 5.2.1 ignores the animation speed, and the fade "flashes" in Firefox although it doesn't flash in others:
http://orbit-transition.fullsetup.com/521.htm

Same code does not seem to work at all -- initial slide never changes -- in 5.2.2 (using the "full download"):
http://orbit-transition.fullsetup.com/522.htm

or using "custom download" with all options selected:
http://orbit-transition.fullsetup.com/522c.htm

@alexcruztech
Copy link

Hi! I made a mistake, and i added my email address to foundation because i
thought i was going to recive something different but not! So how can i
quit receiving emails from it? I am looking for a way but i can not find
it!

On Saturday, April 5, 2014, friscotx notifications@github.com wrote:

Looks like it is broken in 5.2.2

Very simple fade animation that works fine in all tested browsers in 5.0.0

However same code in 5.2.1 ignores the animation speed, and the fade
"flashes" in Firefox although OK in others:
http://orbit-transition.fullsetup.com/521.htm

Same code does not seem to work at all -- initial slide never changes --
in 5.2.2 (using the "full download"):
http://orbit-transition.fullsetup.com/522.htm

or using "custom download" with all options selected:
http://orbit-transition.fullsetup.com/522c.htm

Reply to this email directly or view it on GitHubhttps://github.com//issues/4847#issuecomment-39636879
.

@rafibomb rafibomb added this to the 5.3 milestone Apr 10, 2014
@danielsamuels
Copy link
Contributor

+1 to the speed and progress bar resetting. I've attached a .gif of an Orbit carousel with a 2 second animation time specified, you can see that the progress bar resets on animationend. What would ideally happen is that the bar pauses while the animation takes place, then resumes once the animation is complete.

orbit-progress-2

@rafibomb rafibomb removed this from the 5.3 milestone Jun 2, 2014
@thedeerchild
Copy link
Contributor

For the upcoming 5.3 release we've removed the CSS animation components of Orbit. This should mean that the animation speed can be configured properly though the JS settings.

@thedeerchild thedeerchild self-assigned this Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants