Top Bar mobile_show_parent_link only appears at Small breakpoint

[ricardo-lewis]

The JS generated markup:

<li class="parent-link show-for-small-only">
<a class="parent-link js-generated" href="/products-services">Products &amp; Services</a>
</li>

It would be nice if the Parent Link would show at the $topbar-breakpoint instead of at Small only.

[rafibomb]

Can you submit a PR because this would help others?

[rafibomb]

The parent links visibility needs to match the top-bar breakpoint, not the grid breakpoint.

[jamieshark]

@gakimball Do we have a class that can signify a 'topbar breakpoint show/hide' behavior?

[ricardo-lewis]

@JeanieC that's a good idea – I can already think of places outside the Top Bar where I would use this. Quite a few elements change appearance at the TB breakpoint...

[vita10gy]

I've recently added this as a breakpoint, and came here to add this issue of the parent link as a request .

I'd be willing to make a pull request if those in the know think there's a good chance they'd accept it.

What would be a good name for this breakpoint? Is there "official" foundation lingo for the full desktop menu vs the mobile menu?

Also, while I was at it, it's always bugged me that $topbar-media-query is defined right below $topbar-breakpoint, but doesn't actually use $topbar-breakpoint.

[jamieshark]

@vita10gy If you want to submit a pull request and all looks good, we'd be happy to pull it in. There's no official lingo, but exporting a class something along the lines of "hide-for-topbar-mobile" or "hide-for-topbar-desktop" should be fine. After you submit the pull request, the team will look over it and see if there are any changes that we might want to commit on our end as well.

[vita10gy]

I also added this breakpoint in to the grid so I could do something the equiv of topbar-desktop-5 That way I could make the header above the menu play ball with the menu breakpoint and visibility classes we're talking about.

Would that interest people, or it that getting too specific?

Also, one "catch" to this change we're discussing is that, as far as I can tell at least, though truth be told I didn't spend a ton of time on trying alternatives: the breakpoint needs to be defined with the others in _globals and not _topbar.

Is that too "breaking" to justify for this? I think you could maybe make a case it belongs there anyway.

[rafibomb]

Thanks for pointing this out. Ideally the visibility would match the top-bar breakpoints. We're not adding any features to Foundation 5 as we're concentrating on getting Foundation 6 out.