Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation small bug #37

Closed
jjamor opened this issue Aug 1, 2015 · 6 comments
Closed

Navigation small bug #37

jjamor opened this issue Aug 1, 2015 · 6 comments

Comments

@jjamor
Copy link
Contributor

jjamor commented Aug 1, 2015

Hi!

I've discovered two small issues in navigation.

It is present in https://phlow.github.io/feeling-responsive/ and also in my own blog.

With "big" screens, standard browser, Blog menu consists of three elements:

  • Blog (dropdown), with a link to /blog/
    • Blog entry (link to /blog/)
    • Blog archive entry (link to /blog/archive)

When you reduce size or ipad browser, you will see:

  • Blog (dropdown), without link to /blog, when you click here you will see "back"
    • Blog link
    • Blog archive link

But in android, you will see:

  • Blog (dropdown), without link to /blog, when you click here you will see "back"
    But then you will see three links:
    • Blog (I assume this is the link present in Blog dropdown)
    • Blog link
    • Blog archive link

I think this behaviour should be the same in all devices with small screens.

On the other hand, if I remove link to "/blog/" in the dropdown (_data/navigation.yml), a link
to first drop down element is created. It should not have any link, I guess.

I tried to fix it without success ... 😞

@jjamor
Copy link
Contributor Author

jjamor commented Aug 1, 2015

Some captures...

IPAD / reduced browser in PC:
ipad-sample

Android phone:

android-sample

@Phlow
Copy link
Owner

Phlow commented Aug 3, 2015

You're totally right: it should look everywhere the same.

The »mistake« was in _navigation.yml › There were two times a link to Blog. I reduced it. Now it looks better. And the dropdown on desktop browsers has now only a dropdown with Blog Archive

@Phlow Phlow closed this as completed Aug 3, 2015
@TWiStErRob
Copy link
Contributor

Actually that <li><a... is generated from JavaScript. It's a known Foundation issue: foundation/foundation-sites#6248 awaiting a PR.

You can patch it for yourself in two ways:

  • to show it on both mobile and tablet:
    replace parent-link show-for-small-only with parent-link show-for-medium-down in javascript.js and javascript.min.js

  • to hide it in both mobile and tablet:
    add the mobile_show_parent_link option like below in _includes/navigation.html:

    <nav class="top-bar" data-topbar data-options="mobile_show_parent_link:false">

Tip: you can reduce the browser size to mobile width by attaching the Developer Tools to the right of the window (Chrome: button next to close button) and resizing it by its left edge to squeeze the webpage width small enough.

@Phlow I was just writing this up when you commented :)

@TWiStErRob
Copy link
Contributor

The documentation menu has the same problem.

@Phlow
Copy link
Owner

Phlow commented Aug 3, 2015

I did the adjustment to documentation...

In the future, I have to update the whole foundation thing. But I have no time today left to do it and when I want to do it, I have to do it carefully ;)

jjamor added a commit to jjamor/dramor-blog that referenced this issue Aug 3, 2015
@jjamor
Copy link
Contributor Author

jjamor commented Aug 3, 2015

Hey @TWiStErRob: I've applied the workaround you suggest in javascript.js and javascript.min.js in my blog, and now it apparently is OK! Many thanks!

ArchGalileu added a commit to ArchGalileu/biodanza that referenced this issue Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants