New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Utilities: Foundation #9608
Comments
But there are callouts too http://foundation.zurb.com/sites/docs/callout.html |
Even if I perfectly understand why these helper classes could be convenient, I feel like it encourages bad CSS practices. This is the kind of things you should define at component level, as it is done for buttons for example: http://foundation.zurb.com/sites/docs/button.html#coloring Because font and background colors are linked (you don't want black text on black background for example), it doesn't feel right to have to do this: <div class="background-black text-white">White text in a black div</div> That said, I know there are use-cases where text colors helpers are the right way to go so I don't know... I'd love to hear what others think about that. |
I like your thought for backgrounds to be defining at component level .... i have to say that but for text colors , i am a little bit confused! |
We cannot add "color helpers" just to let the user changing the color where ze wants to because color itself is not semantical. It complexify the HTML markup and, like @Deckluhm said, it lead to bad practices. The only proper way to define styles is with CSS directly. HTML markup should only contain abstract component and behavior helpers. |
Ohk no issue @ncoden ..... Closing this |
That's why I added the |
@DaSchTour if thats the case, {{ Because i think you are the right person for it }} |
@IamManchanda I would suggest to create some kind of plugin that fits to foundation for this. Any ideas for a cool name? |
@DaSchTour Rainbow. |
@DaSchTour Are you talking about which component/utility here ? |
@IamManchanda oh yes. Total confusion about which thread I was on. |
Hmmnnn so which comp/utility you were talking about ? |
@IamManchanda what's the status of this? Thanks. |
Closing as we did not receive further feedback. Feel free to reopen if you want to pick that up (and open a draft PR then). |
Similar to Buttons => http://foundation.zurb.com/sites/docs/button.html
I think there should be text and background based color utilities ( helper classes ) in foundation
For text something like
and for backgrounds something like
As, i dont think there is any humongous need for
.background.white
&.background.dark
so haven't included in my above codeThe text was updated successfully, but these errors were encountered: