Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Buttons (CSS Classes) #9646

Closed
IamManchanda opened this issue Jan 13, 2017 · 3 comments
Closed

Social Buttons (CSS Classes) #9646

IamManchanda opened this issue Jan 13, 2017 · 3 comments

Comments

@IamManchanda
Copy link
Contributor

IamManchanda commented Jan 13, 2017

Motivation: http://mdbootstrap.com/components/social-buttons/

Can be a perfect partner to http://zurb.com/playground/foundation-icon-fonts-3

What it will help us achieve

<button type="button" class="button facebook">
  <i class="fi-social-facebook"></i>
</button>

Use Case: Can be very helpful for social login, sharing and more!

{{ Rest on you guys to decide }}

@ncoden
Copy link
Contributor

ncoden commented Jan 13, 2017

This is not a bad idea, but I see a main problem: "Social Buttons" is a design modifier of Button, while social buttons can take a lot of different and various designs.

What design should we provide by default ?
Would most of the users have to customize their design anyway ?

@IamManchanda
Copy link
Contributor Author

IamManchanda commented Jan 14, 2017

Provide a icon with white color ( or black if in case light background ) and background with the color of the social brand ..... simple buttons like normal foundation buttons

And let them decide to choose this

<button type="button" class="button facebook">
  <i class="fi-social-facebook"></i>
</button>

or this,

<button type="button" class="button facebook">
  <i class="fi-social-facebook"></i>Facebook 
</button>

or this ,

<button type="button" class="button facebook">
  <i class="fi-social-facebook"></i>Log in with Facebook 
</button>

Hope you get my idea ?

@IamManchanda
Copy link
Contributor Author

To anyone concerned .... moving this to building blocks!

rafibomb pushed a commit to zurb/building-blocks-ARCHIVED that referenced this issue Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants