Issue 10416 - input-group buttons not sized properly #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted height for flex mode to fill parent container. Added two tests - one for flex/xygrid and the other for flow mode.
|
Thanks digging it in! |
|
@gskaplan Please rename |
|
Renamed and new PR created. |
scss/forms/_input-group.scss
Outdated
| @@ -107,6 +107,7 @@ $input-prefix-padding: 1rem !default; | |||
|
|
|||
| @if $global-flexbox { | |||
| flex: 0 0 auto; | |||
| display: flex; | |||
There was a problem hiding this comment.
Display first and then flex shorthand property
See https://github.com/zurb/foundation-sites/blob/develop/.sass-lint.yml#L151-L153
…input-group-buttons-sizing
As suggested by @IamManchanda: #10456 (comment)
This was referenced Aug 4, 2017
Re-order CSS properties
|
Thanks... |
|
Excellent work. Thanks @gskaplan! And congratulations on first merged PR! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolve the issue where input-group-buttons aren't filling up the entire space of the parent container. Thanks to @rafibomb for helping with the code. This relates to issue #10416.
Please review as necessary. @IamManchanda.