Resolves issue#10657 (When closeOnClick option is true, clicking on t… #10658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he dropdown element should not close it.)
|
@u671175 thanks for this PR! I've just run into the same issue because my dropdown closed when clicking in it. One note regarding your PR: It's not enough to only mention it in the commit message 😉 |
|
@SassNinja Given the changes made in this PR - is ready for merge? |
|
@rafibomb yes, looks good in my eyes and ready to merge |
This was referenced Jun 16, 2018
Merged
SassNinja
added a commit
to SassNinja/foundation-sites
that referenced
this pull request
Sep 6, 2018
This prevents the dropdown pane from closing if clicking in it. Hopefully this gets merged because it's no my PR ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data-close-on-click option on dropdown does not work correctly #10657