Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed $foundation-palette to $button-palette #10815

Merged
merged 1 commit into from Dec 24, 2017

Conversation

RudolfBos
Copy link

Fixes #10576

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RudolfBos 👍
Welcome among the Foundation contributors ;)

@ncoden
Copy link
Contributor

ncoden commented Dec 24, 2017

@RudolfBos For your next pull request, you can push your work to a dedicated branch (like fix/use-button-palette-for-button-group-10576 and create a pull request from it. So you can continue working on your develop branch without polluting your pull requests.

@ncoden ncoden merged commit 1b8e847 into foundation:develop Dec 24, 2017
@RudolfBos
Copy link
Author

Thx @ncoden! Will do that next time.

@IamManchanda
Copy link
Contributor

@RudolfBos You can look at #10576 (comment) if you have any doubts for the same ;)

ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
c36cdf4 Changed `$foundation-palette` to `$button-palette`

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants