Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not generate invalid xy-cell when breakpoint is not found #10821

Merged

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Dec 24, 2017

For the following code:

.test {
  @include xy-cell(12, $breakpoint: small);
  @include xy-cell(12, $breakpoint: xxx-invalid-breakpoint-xxx);
}

Generate the following code:

.test {
  width: calc(100% - 1.25rem);
  margin-right: 0.625rem;
  margin-left: 0.625rem;
}

And gives this warning:

WARNING: xy-cell: no gutters were found in `$gutters` for "$breakpoint: xxx-invalid-breakpoint-xxx", cell was not generated`
Backtrace:
	../foundation-sites/scss/xy-grid/_cell.scss:142, in mixin `xy-cell`
	...

Not: a refactor of breakpoints seems necessary to ensure we have this behavior across the whole framework.

@ncoden
Copy link
Contributor Author

ncoden commented Dec 25, 2017

IamManchanda self-assigned this 23 hours ago

@IamManchanda Do you want to review this ?

@ncoden
Copy link
Contributor Author

ncoden commented Dec 27, 2017

poke @IamManchanda

@ncoden ncoden merged commit 27fd4ed into foundation:develop Jan 7, 2018
@ncoden ncoden deleted the fix/xy-cell-with-invalid-breakpoint branch April 7, 2018 17:46
@ncoden ncoden modified the milestone: 6.5.0 Apr 20, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…d-breakpoint for v6.5.0

e0f8eae fix: do not generate invalid xy-cell when breakpoint is not found

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants