-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add opening methods to responsiveAccordionTabs #10953 #10961
feat: add opening methods to responsiveAccordionTabs #10953 #10961
Conversation
Will test tomorrow. |
Seems fine so far. But what about |
Actually I still need to work on this. At least to improve the API for tabs. It is a bit difficult to understand what you need to pass to So I'll take a look at |
Do we also need some unit tests then? |
Yes, there's never enough unit tests ;) |
Any news on this? |
No, just need some time to work on this. |
Is |
Bump =) |
I seen your message but as you can see this is new features planned for Thx for the bump anyway =) |
Ah ok, was not quite clear from the changes in the comment section, only on the right side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with patch-package in 6.4.3, works great.
doot. Would be cool to have this merged soon! |
@DanielRuf it looks like you reviewed and tested this, is it good to merge? |
Not sure but a few things are missing but I think it can be merged as it implements most of the currently missing things. |
OK based on prior comment going to merge this |
This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there: https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1 |
Changes:
Closes #10953
Note:
open/toggle
methods are not supported in tabs mode.