Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy the sourcemap files #10998

Merged
merged 2 commits into from Mar 4, 2018
Merged

fix: copy the sourcemap files #10998

merged 2 commits into from Mar 4, 2018

Conversation

DanielRuf
Copy link
Contributor

This copies the sourcemap files for the unminified development files.

Closes #10997

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some research and there seems to be no problem with publishing sourcemap to production. So LGTM 👍 .

@@ -58,6 +59,9 @@ gulp.task('deploy:dist', ['sass:foundation', 'javascript:foundation'], function(
.pipe(rename({ suffix: '.min' }))
.pipe(gulp.dest('./dist/css'))
.pipe(cssFilter.restore)
.pipe(sourcemapFilter)
.pipe(gulp.dest('./dist/css'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tabulation here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will change it tomorrow morning if this is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@ncoden ncoden merged commit ec293bf into foundation:develop Mar 4, 2018
@DanielRuf DanielRuf deleted the fix/copy-sourcemap-files-10997 branch March 4, 2018 16:46
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…iles-10997 for v6.5.0

0ac0fcd fix: copy the sourcemap files (foundation#10998)
4dbf90b add missing indentation

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants