Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the browserslist config according to the compability table #11021

Merged
merged 3 commits into from Apr 22, 2018
Merged

chore: update the browserslist config according to the compability table #11021

merged 3 commits into from Apr 22, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Mar 7, 2018

The browserslist config was not consistent and did not set supported browsers versions. This removed the support for Safari 9 and older as these are not supported anymore and have many bugs that can not be easily solved with a few workarounds.

https://foundation.zurb.com/sites/docs/compatibility.html

Reference: #9123

Also Apple does not support older versions (just 11?).

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update the compatibility according to the documentation, but I am not sure this is what we should do. The compatibility list is inconsistent with Android Browser v2.3 (0% usage, same for v3/v4 and 8 year old) and without Safari 9 (0.5% usage, iOS 9 so iPhone 4S/5/5C/6/6S/SE, 2.5 year old).

We can have some bugs in older browsers, this is always better than unsupporting it.

So... do we drop iOS 9 or do we update the documentation.

@DanielRuf
Copy link
Contributor Author

iPhone 4S/5/5C/6/6S/SE

Attention, these devices still get OS upgrades / updates. Even for Safari ;-)

@DanielRuf
Copy link
Contributor Author

do we update the documentation.

This would introduce more work than before. Safari 9 is quite old and the Foundation Sites 6 docs were like this the whole time I guess.

Deprecating old Safari versions should be ok.

We might either increase the Android version or check for android_chrome in general instead of Android. But this would be another step and for 6.5 probably useful.

@ncoden
Copy link
Contributor

ncoden commented Mar 7, 2018

Attention, these devices still get OS upgrades / updates. Even for Safari ;-)

Yes, expect for 4s.

Deprecating old Safari versions should be ok.

Yes, but I am not sure about Safari 9. And again, I would prefer a partial support (with autoprefixer doing its job even if we didn't check if everything works correctly) and add it to the doc rather than dropping the CSS support and going for "it cost us nothing but we'll drop it anyway".

@DanielRuf
Copy link
Contributor Author

How do we proceed with this one?

@ncoden
Copy link
Contributor

ncoden commented Mar 17, 2018

@DanielRuf I would go for keeping iOS 7 in the CSS compatibility table (we can drop Android 2.3 and use Android 4.4 instead) and add a "partial support" section in the documentation with something like: "Actively supported but with some known bugs."

We want to support these browsers as they are not too old, but sadly sometimes there is a bug that we can't resolve, too bad. It's always better than dropping the support (and creating new bugs).

What do you think ?

chore: add note about old iOS versions
@DanielRuf
Copy link
Contributor Author

Pushed a new commit with a few changes. Please check if this is better.

</tr>
</table>

<sup>1</sup>iOS 7+ is actively supported but with some known bugs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does all iOS 7+ versions have bugs ? ;)
Please add the concerned versions and links to the issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the concerned versions and links to the issues.

Well, this would be many. iOS Safari <= 10 has flexbugs issues and there are also numerous issues with Safari 9. And both are officially not supported by Apple anymore. That's why I wanted to make a cut. We can not support all these old and problematic Safari releases (which also did not support required form fields and so on).

So "some known bugs" is not right in my opinion.

https://www.reddit.com/r/web_design/comments/3la04p/psa_safari_on_ios9_has_a_media_query_bug/

Safari is the new IE for us in the frontend ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any time a web browser is tied to the release cycle of an OS it's going to be bad. IE suffered from this problem in the past and Safari both on iOS and the main OS suffers from not being on an independent release cycle. It's really stupid.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @colin-marshall @SassNinja @JeremyEnglert ?
Foundation is known for its compatibility with older browsers (even if it's a bit less true now with flex & XY grid).

See the discussion above #11021 (comment)

@ncoden
Copy link
Contributor

ncoden commented Apr 11, 2018

@DanielRuf I think we can keep this PR as is for now, and start to drop olders browsers supports (like at least Safari 7 & 8) at the next minor version, as we try to make v6.5.0 keeping maximum compatibility with v6.4.4-rc1. What do you think ? (poke @SassNinja)

@ncoden
Copy link
Contributor

ncoden commented Apr 22, 2018

Poke @DanielRuf. #11021 (comment)

@DanielRuf
Copy link
Contributor Author

What do you think ? (poke @SassNinja)

This?

The other is clear (keep it open for now?) to me.

@ncoden
Copy link
Contributor

ncoden commented Apr 22, 2018

The other is clear (keep it open for now?) to me.

I don't understand. I meant merging it like this with support for android >= 4.4, ios >= 7 and ie >= 9, and dropping old ios versions at v6.6.

@DanielRuf
Copy link
Contributor Author

I don't understand. I meant merging it like this with support for android >= 4.4, ios >= 7 and ie >= 9, and dropping old ios versions at v6.6.

That's what I mean. Thought you need any further commit or change here which does not seem to be the case.

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncoden ncoden merged commit 4448520 into foundation:develop Apr 22, 2018
@DanielRuf DanielRuf deleted the chore/compability-update-browserslist-9123 branch April 22, 2018 21:45
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…date-browserslist-9123 for v6.5.0

6999b7a chore: update the browserslist config according to the compability table
94d6eca chore: drop support for Android 2.3 - 4.4

Co-Authored-By: Daniel Ruf <daniel@daniel-ruf.de>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants