fix: add aria-expanded to the toggler trigger #11052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
suggested changes
Mar 14, 2018
| <a data-open="toggler">Open</a> | ||
| <a data-close="toggler">Close</a> | ||
| <a data-toggle="toggler">Toggle</a> | ||
| </div>`).appendTo('body'); |
There was a problem hiding this comment.
Can you use a generator here to avoid code duplication ?
There was a problem hiding this comment.
Ok, will prepare it then.
| $('#toggler').should.have.attr('aria-expanded', 'true'); | ||
| $triggers.find('[data-open]').should.have.attr('aria-expanded', 'true'); | ||
| $triggers.find('[data-close]').should.have.attr('aria-expanded', 'true'); | ||
| $triggers.find('[data-open]').should.have.attr('aria-expanded', 'true'); |
There was a problem hiding this comment.
open, close, open. Should't it be toggle?
Also, Cannot we use ('[data-open], [data-close], [data-toggle]') here, or would this test for only the first element / one element and not every ?
There was a problem hiding this comment.
Not sure here about toggler. Will check it then.
| $('#toggler').should.have.attr('aria-expanded', 'true'); | ||
| $triggers.find('[data-open]').should.have.attr('aria-expanded', 'true'); | ||
| $triggers.find('[data-close]').should.have.attr('aria-expanded', 'true'); | ||
| $triggers.find('[data-open]').should.have.attr('aria-expanded', 'true'); |
There was a problem hiding this comment.
Unit tests. So let's tests only what the function should do alone and not all its side-effects. We tested that aria attribute are well set and updated above, no need to repeat it there.
| $('#toggler').should.have.attr('aria-expanded', 'false'); | ||
| $triggers.find('[data-open]').should.have.attr('aria-expanded', 'false'); | ||
| $triggers.find('[data-close]').should.have.attr('aria-expanded', 'false'); | ||
| $triggers.find('[data-open]').should.have.attr('aria-expanded', 'false'); |
|
Pushed an update with the proposed changes. |
ncoden
approved these changes
Mar 17, 2018
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aria-expandedattribute should be on the trigger not the container of the toggled element(s).References:
https://www.w3.org/WAI/GL/wiki/Using_aria-expanded_to_indicate_the_state_of_a_collapsible_element
http://3needs.org/en/testing/code/aria-expanded.html
http://www.3needs.org/en/testing/code/aria-expanded-code.html
Closes #11049