Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply menubar aria role instead of menu #11099

Merged
merged 1 commit into from Mar 29, 2018
Merged

fix: apply menubar aria role instead of menu #11099

merged 1 commit into from Mar 29, 2018

Conversation

DanielRuf
Copy link
Contributor

menu was used but this is not a valiad aria role. menubar is the right aria role.

Closes #11097

@ncoden
Copy link
Contributor

ncoden commented Mar 27, 2018 •
edited

@DanielRuf As said in #11097, I am not able to reproduce the issue. Did you get role="menu" applied somewhere in responsiveMenu ?

@DanielRuf
Copy link
Contributor Author

Well, this line still uses role: menu ;-)

@ncoden
Copy link
Contributor

ncoden commented Mar 27, 2018 •
edited

I seen that. But for what then ?

@DanielRuf
Copy link
Contributor Author

There is no role: menu in the WCAG spec. Just menubar. This is the only place where we still have menu.

@DanielRuf
Copy link
Contributor Author

I guess nested (sub)menues like the code says it.

ncoden
ncoden approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so LGTM as we have to do that change anyway but this does not close #11097.

@ncoden ncoden merged commit efafa15 into foundation:develop Mar 29, 2018
@DanielRuf DanielRuf deleted the fix/apply-menubar-aria-role-11097 branch March 29, 2018 21:18
@ncoden ncoden added this to the 6.5.0 milestone Apr 23, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@DanielRuf @ncoden
Use pull request foundation#11099 from DanielRuf/fix/apply-menubar-ar…
8c7f7ca 
…ia-role-11097 for v6.5.0

73f26a9 fix: apply menubar aria role instead of menu

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
accessibility javascript utilities
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielRuf @ncoden