Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: spelling corrections in typography #11257

Merged
merged 2 commits into from May 13, 2018
Merged

docs: spelling corrections in typography #11257

merged 2 commits into from May 13, 2018

Conversation

datatypevoid
Copy link

Description

Two minor spelling corrections.

  • Closes

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@DanielRuf DanielRuf self-requested a review May 13, 2018 11:10
DanielRuf
DanielRuf approved these changes May 13, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DanielRuf DanielRuf added the scss label May 13, 2018
@ncoden ncoden changed the title docs: spelling corrections docs: spelling corrections in typography May 13, 2018
ncoden
ncoden approved these changes May 13, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @datatypevoid 👍. I renamed your PR. Next time could you use a specific PR and commit name ?

docs: spelling corrections
⏬
docs: spelling corrections in typography

@ncoden ncoden merged commit ca94337 into foundation:develop May 13, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11257 from datatypevoid/spelling-correcti…
678ab4c 
…ons for v6.5.0

7ef7598 docs: add spacing between words
38df69a docs: spelling corrections

Co-Authored-By: David Niciforovic <david.r.niciforovic@gmail.com>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
scss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@datatypevoid @DanielRuf @ncoden