fix: avoid viewport height for fullscreen Reveal as it may be incorrect #10879 #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foundation#10879 The CSS viewport is the larger possible view height and does not change with the visible area height. This is an intended behavior for optimization reason. See this article: See: https://nicolas-hoizey.com/2015/02/viewport-height-is-taller-than-the-visible-part-of-the-document-in-some-mobile-browsers.html See: foundation#10879 (comment) Closes foundation#10879
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Aug 25, 2018
…height-10879 for v6.5.0 fd04798 fix: avoid viewport height for fullscreen Reveal as it may be incorrect foundation#10879 Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prefer the
top+right+bottom+lefttrick to make the fullscreen modal taking the whole window height and width, instead of an height based on the viewportvhas in mobile browser this CSS unit may not represent correctly the visible area.Motivation and Context
The CSS viewport
vhis the larger possible view height and does not change with the visible area height (this is an intended behavior for optimization reason).Because of that, the modal may be taller than the visible area and the window, and is then incorrectly positioned.
Types of changes
functionality to change)
Checklist (all required):
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).