Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interchange parsing rules, allow filename to contain brackets #11529

Merged
merged 1 commit into from Oct 9, 2018
Merged

Fix interchange parsing rules, allow filename to contain brackets #11529

merged 1 commit into from Oct 9, 2018

Conversation

peterquentin
Copy link
Contributor

Description

This regular expression fix makes parsing the interchange rules more explicit by looking for the complete pattern.

<img data-interchange="[/media/_thumbs/_generated/400x0/[media-168]image.jpg?1539097863, small], [/media/_thumbs/_generated/1024x0/[media-168]image.jpg?1539097863, medium], [/media/_thumbs/_generated/1280x0/[media-168]image.jpg?1539097865, large]">
  • Closes

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@peterquentin
Fix parsing rules, allow filename to contain brackets
a3b25c0 
This regular expression fix makes parsing the interchange rules more explicit by looking for the complete pattern.
ncoden
ncoden approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peterquentin 👋, Thank you for your pull request.

It looks good to me. 👍 See https://regex101.com/r/IqlFDn/1/

@ncoden ncoden merged commit 1fd8149 into foundation:develop Oct 9, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Oct 11, 2018
@peterquentin @ncoden
Use pull request foundation#11529 from peterquentin/peterquentin-patc…
a342176 
…h-1 for v6.5.0

a3b25c0 Fix parsing rules, allow filename to contain brackets

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this pull request Oct 11, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
bug fix Interchange
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterquentin @ncoden