Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add required checkbox support to Abide #11720

Merged

Conversation

SassNinja
Copy link
Contributor

Description

This picks up my old PR #8937 whose history got messed up.

Abide did only support required correctly for radio buttons and not for checkboxes. This PR adds checkboxes support.
Now one required checkbox will make the whole group/fieldset required.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@SassNinja SassNinja self-assigned this Jul 25, 2019
@SassNinja SassNinja added this to the 6.6.0 milestone Aug 7, 2019
@SassNinja SassNinja merged commit 86deccd into foundation:develop Aug 12, 2019
@SassNinja SassNinja deleted the fix/11683_abide_checkbox_group branch August 12, 2019 10:34
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Abide] Required on Radio Group doesn't work
3 participants