Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Equalizer Responsive #6373

Closed
wants to merge 5 commits into from
Closed

Make Equalizer Responsive #6373

wants to merge 5 commits into from

Conversation

tyrantkhan
Copy link
Contributor

#4882 Made Reference to this

The issue comes up if you have set equalize_on_stack to true. I opted for a solution where you set the media query on the parent, and not on a per element basis.

Maybe there is value in having it there for both objects, but I'm not sure that's feasible given the current implementation. I was not looking to do a whole rewrite.

Finally, I would have liked to put the value in just the data-equalizer attribute, but Nested elements are actually using that space, so i opted for a new attribute data-equalizer-mq. If you set it to some non-existant query like data-equalizer-mq="only-megalarge", the plugin will just ignore your media query request and continue as if you passed no media query.

@tyrantkhan
Copy link
Contributor Author

i messed up my fork a bit by doing the PR off master, so i purged it, i'm going to resubmit this again in a bit.

@tyrantkhan tyrantkhan closed this Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants