changes to make equalizer responsive and the associated docs #6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4882 Made Reference to this
The issue comes up if you have set equalize_on_stack to true. I opted for a solution where you set the media query on the parent, and not on a per element basis.
Maybe there is value in having it there for both objects, but I'm not sure that's feasible given the current implementation. I was not looking to do a whole rewrite.
Finally, I would have liked to put the value in just the data-equalizer attribute, but Nested elements are actually using that space, so i opted for a new attribute data-equalizer-mq. If you set it to some non-existant query like
data-equalizer-mq="only-megalarge", the plugin will just ignore your media query request and continue as if you passed no media query.