Add arrow color variables to menu components #7515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds accordion menu arrow color variable. I noticed I couldn't easily change this when working on a new project.
Added dropdown menu anchor color variable so this can be customised
Add drilldown arrow color variable so this can be changed.
|
I like this idea @gakimball what do you think? |
|
I figured this would be requested eventually, thanks for putting it together! Can you resolve the merge conflicts? |
|
@gakimball Any pointers on how to do that? Sorry I'm pretty new to using Git and haven't worked out how to do that yet... |
|
In the folder of your Foundation fork, run this: # Adds a remote reference to the official repo
git remote add foundation https://github.com/zurb/foundation-sites.git
# Downloads references to branches
git fetch foundation
# Merge the "develop" branch of Foundation into your work
git merge foundation/developI think that works. |
# Conflicts: # scss/components/_dropdown-menu.scss
|
thanks @gakimball I hope I've done that correctly! This and 7514 will be a big help in my current project 😃 |
|
@brettdewoody Yep! Now I can merge it automatically, thanks :) |
gakimball
added a commit
that referenced
this pull request
Dec 17, 2015
Add arrow color variables to menu components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds arrow color variables to dropdown menu, drilldown and accordion menu. I recently tried to change the arrow colors in a recent project but found I wasn't able to, hence this!