Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex Video –> Responsive Embed #8765

Merged
merged 2 commits into from Oct 5, 2016

Conversation

andycochran
Copy link
Contributor

This PR renames "Flex Video" to "Responsive Embed" so that it's clear that embedded content does not have to be a video (maps, calendars, widgets, etc). The documentation are also updated to be more clear, with video examples in the appropriate aspect ratios and an example of how to use custom ratios.

Note: The .flex-video class and flex-video mixin are to be deprecated in a future version (6.4?).

Closes #8199.

@designerno1
Copy link
Contributor

designerno1 commented May 11, 2016

looks good to me
i made a few device tests from the docs page
a docs redirect from flex-video.html to responsive-embed.html then would be nice

@andycochran
Copy link
Contributor Author

@designerno1, can I set up redirects in the repo? I think Zurb will need to set up a manual redirect for docs/pages/flex-video.md –> docs/pages/responsive-embed.md.

@designerno1
Copy link
Contributor

@andycochran
don't think it is possible in repo, also think zurb have to do that

@rafibomb
Copy link
Member

rafibomb commented May 31, 2016

Good work @andycochran and thanks for chiming in @designerno1. We can do this re-direct on our servers. I like it, just would like to get @kball to take a look so we can plan a smooth transition.

@rafibomb rafibomb added this to the 6.3 milestone Jul 11, 2016
@rafibomb
Copy link
Member

Ok looks good! Perhaps we also target the search (autocomplete) to suggest responsive embed when people type flex-video

You can do it in the front mattrr of the page

@andycochran
Copy link
Contributor Author

@rafibomb Is this what tags are for in the frontmatter?

@kball kball merged commit 66bf055 into foundation:v6.3 Oct 5, 2016
@kball
Copy link
Contributor

kball commented Oct 5, 2016

Awesome. I added some tags in the front matter so it will show up in search.

Now adding a reminder for when we put together the release & release notes:

On Release we should add a redirect

@kball
Copy link
Contributor

kball commented Dec 1, 2016

@andycochran can you put together a quick migration note for this in this PR?

@andycochran
Copy link
Contributor Author

Migration Note

The .flex-video class and flex-video() mixin will be deprecated in a future version (6.4). They have been replaced by the .responsive-embed class and responsive-embed() mixin. This is a semantic improvement, as embedded content does not have to be a video.

@ctbarber
Copy link

@rafibomb I noticed that .responsive-embed class dropped the padding-top for the vimeo class. It was included in the flex-video.

Is that no longer needed now?

@andycochran
Copy link
Contributor Author

@ctbarber Are you noticing issues with your Vimeo embeds?

I'm not sure I understand what padding-top: 0; was doing for Vimeo, as the default .responsive-embed class has no top padding. If there are issues with Vimeo, we could probably add that style for all responsive embeds and avoid the .vimeo class.

@ctbarber
Copy link

ctbarber commented Apr 12, 2017

@andycochran no, not seeing any issues. Looks same with .responsive-embed class as it did with flex-video vimeo classes as best that I can tell. Just wanted to be sure that vimeo class was something that could be dropped since I didn't see any mention of it going away. Thanks for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants