New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex Video –> Responsive Embed #8765
Conversation
looks good to me |
@designerno1, can I set up redirects in the repo? I think Zurb will need to set up a manual redirect for |
@andycochran |
Good work @andycochran and thanks for chiming in @designerno1. We can do this re-direct on our servers. I like it, just would like to get @kball to take a look so we can plan a smooth transition. |
Ok looks good! Perhaps we also target the search (autocomplete) to suggest responsive embed when people type flex-video You can do it in the front mattrr of the page |
@rafibomb Is this what |
Awesome. I added some tags in the front matter so it will show up in search. Now adding a reminder for when we put together the release & release notes: On Release we should add a redirect |
@andycochran can you put together a quick migration note for this in this PR? |
Migration NoteThe |
@rafibomb I noticed that Is that no longer needed now? |
@ctbarber Are you noticing issues with your Vimeo embeds? I'm not sure I understand what |
@andycochran no, not seeing any issues. Looks same with |
This PR renames "Flex Video" to "Responsive Embed" so that it's clear that embedded content does not have to be a video (maps, calendars, widgets, etc). The documentation are also updated to be more clear, with video examples in the appropriate aspect ratios and an example of how to use custom ratios.
Note: The
.flex-video
class andflex-video
mixin are to be deprecated in a future version (6.4?).Closes #8199.