Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attach accordion elements that are not marked as accordion-item #9178

Merged
merged 1 commit into from Oct 25, 2016

Conversation

DaSchTour
Copy link
Contributor

I think this is a relict from an older version, where data-accordion-item was not used.
I'm aware of the fact, that this is a breaking change, but as the documentation tell's the developer to use data-accordion-item I think it shouldn't fallback to use li. This way it is also possible to add list items to an accordion that have no content. Till now having to content section throws an ugly hard to debug javascript error.

@kball
Copy link
Contributor

kball commented Oct 25, 2016

I think this is the right direction to go, but we'll need to make sure we highlight this as a breaking change requiring a possible migration.

@kball
Copy link
Contributor

kball commented Oct 25, 2016

Migration Note: Accordions used to instantiate items for any child li, but they should only instantiate an item for a child marked with data-accordion-item. If you depended on the former behavior, you will need to add the data-accordion-item attribute.

@kball kball merged commit dc1d5a5 into foundation:v6.3 Oct 25, 2016
@kball kball added this to the 6.3 milestone Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants